Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow parsing CSR extensions with the critical bit having an explicitly encoded default #6600

Merged
merged 2 commits into from
Nov 13, 2021
Merged

Allow parsing CSR extensions with the critical bit having an explicitly encoded default #6600

merged 2 commits into from
Nov 13, 2021

Conversation

alex
Copy link
Member

@alex alex commented Nov 13, 2021

Closes #6370
Fixes #6368

reaperhulk
reaperhulk approved these changes Nov 13, 2021
View reviewed changes
Copy link
Member

@reaperhulk reaperhulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiran, just checking in here to say that we're planning on carrying this patch for roughly 6 months as a transitional window.

@reaperhulk reaperhulk merged commit 4da2a68 into pyca:main Nov 13, 2021
@alex alex deleted the csr-extension-shenangins branch November 14, 2021 03:16
@reaperhulk reaperhulk mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reaperhulk reaperhulk reaperhulk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cryptography 35.0.0 fails to parse FreeIPA server CSR
2 participants
@alex @reaperhulk