✨ Add to GPS API #630
Merged
✨ Add to GPS API #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillXuCodes
requested changes
Feb 10, 2024
WillXuCodes
requested changes
Feb 10, 2024
noam987
previously approved these changes
Feb 19, 2024
WillXuCodes
previously approved these changes
Feb 23, 2024
|
Changed the degree ranges of pitch roll and yaw to correct ranges. Docs changes only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added Gps features
get_x_position()
get_y_position()
get_pitch()
get_roll()
get_yaw()
Fixed
get_rotation() // Now returns the angle unbounded (past +/-360) no long returns intial set rotation
Motivation:
More clear api methods and calls for gps utility
References (optional):
link
Test Plan:
Test X and Y position
Test pitch
Test roll
Test yaw
Test get_rotation