An updated dashboard #109
Merged
An updated dashboard #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <div class='spinner'></div> Loading data... | ||
| <!-- dashboard-numbers --> | ||
|
|
||
| <div id='dashboard-numbers'></div> |
There was a problem hiding this comment.
Above is site_name and this is dashboard-numbers. Can the use of _ or - be picked and standardized?
There was a problem hiding this comment.
Good catch... do you have a preference?
There was a problem hiding this comment.
I do not. I see plenty of _ in the committed JavaScript files, so probably that one.
There was a problem hiding this comment.
The div ids are all --delimited now; local variables are _-delimited.
|
I assigned the "needs work" label until the |
sschneid
force-pushed
the
dashboard2
branch
4 times, most recently
from
b49a8c6 to
bb1e091
Compare
sschneid
force-pushed
the
dashboard2
branch
3 times, most recently
from
814c17f to
afc3fd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stats-vmpooler-*scriptsBootstrap, d3, and jQuery all included for speed optimization.