Fix binarylog by allowing users to specify managed directories

[elfranne]

On Ubuntu/Debian Puppet will fail if specifying path for:

tmpdir
basedir
datadir
innodb_data_home_dir
innodb_log_group_home_dir
innodb_undo_directory
innodb_tmpdir

deb packages starts mysql service automatically after install with the config provided by Puppet but will fail if the directory has not been created. Creating the directory should be part of the installation process.

A solution, less than ideal, is to create the folders (exec) and make them world readable. Then after the package has been installed (and user created) is to fix the permissions and ownership.

If anyone can come up with a more elegant solution...

Has been tested on:
Puppet 6.0.4 + Ubuntu 16.04LTS

[elfranne]

@david22swan Any comments ?

[carabasdaniel]

Hi @elfranne,

This looks good, but would it be possible to add some tests to verify that this is working as intended?

Thanks.

[lionce]

Hello @elfranne ,

Please let us know if you need help on adding some tests for this update! Thank you!

Cheers!

[elfranne]

Help would be greatly appreciated !

[lionce]

Hello @elfranne ,

Currently we're using puppet-litmus for running acceptance tests. This replaces beaker as the test runner. To run the acceptance tests follow the instructions from this point here.
Here is a useful documentation on how to add unit tests using rspec-puppet
To add new unit tests for that here is an example for manage_config_file. Another example for mysql::server::backup. I hope these examples will help you. If you need help, please contact us! Thanks!

Cheers!

[lionce]

Hello @elfranne ,

Apologies for the bother but I was wondering if you intended to do any further work on this pr? Please let us know if you need help on adding the tests for this update!

Thank you!

[fuyar]

Hello any news on this PR ? This is a blocker for guys using Debian as package start mysql on post install scripts.
Typically starting mysql without binlog dir will prevent mysql from starting then package installation is marked as failed.

[carabasdaniel]

This PR looks great now, thank you @elfranne and @sanfrancrisko.

[jocado]

Hmmm, managed_dirs is inherited from params class in to the server class, but not actually declared in the server class. This means it can't be changed.

This functional change, released in 10.5 today, has completely broken this module for us.