Make it possible to use pod's network #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To use pod's network in a container, it shuld have --pod argument and should not have --net. The latter was always being added to the docker run command, if not provided to the class as a parameter, then defaults to 'bridge'. If empty or empty arrar - added as '' which also breaks networking for the container in the pod. With this fix, if a network is not defined, the whole argument will be omitted in the docker run / docker create flags. This is the same as providing previous default 'bridge' if container is created or started without '--pod', and is not breaking compatibility with podman create/run command without explicit '--net' argument.
|
|
docker_run_flags is a functionBreaking changes to this file WILL impact these 1 modules (exact match):Breaking changes to this file MAY impact these 6 modules (near match):docker::run is a typeBreaking changes to this file WILL impact these 6 modules (exact match):Breaking changes to this file MAY impact these 21 modules (near match):
This module is declared in 6 of 576 indexed public
|
adrianiurca
approved these changes
Mar 1, 2021
There was a problem hiding this comment.
Hi @seriv, thank you for your contribution.
kind regards,
@adrianiurca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use pod's network in a container, it shuld have --pod argument
and should not have --net.
The latter was always being added to the docker run command, if
not provided to the class as a parameter, then defaults to 'bridge'.
If empty or empty arrar - added as '' which also breaks networking
for the container in the pod.
With this fix, if a network is not defined, the whole argument will
be omitted in the docker run / docker create flags. This is the
same as providing previous default 'bridge' if container is created
or started without '--pod', and is not breaking compatibility with
podman create/run command without explicit '--net' argument.