Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix array of additional flags #671

Merged

Conversation

CAPSLOCK2000
Copy link

Do not ignore the 'additional_flags' option of docker_networks when it is specified as an array instead of a simple string.
Without this fix 'additional_flags' is silently ignored when it is an array.

@CAPSLOCK2000 CAPSLOCK2000 requested a review from a team as a code owner October 18, 2020 19:21
@codecov-io
Copy link

codecov-io commented Oct 18, 2020

Codecov Report

Merging #671 into main will increase coverage by 0.40%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #671      +/-   ##
==========================================
+ Coverage   22.19%   22.60%   +0.40%     
==========================================
  Files          20       20              
  Lines         757      761       +4     
==========================================
+ Hits          168      172       +4     
  Misses        589      589              
Impacted Files Coverage Δ
lib/puppet/provider/docker_network/ruby.rb 53.84% <66.66%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a2a029...4f20f06. Read the comment docs.

@adrianiurca adrianiurca merged commit ec3159f into puppetlabs:main Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants