Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hiera lookups for resources in init.pp #586

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

fe80
Copy link
Contributor

@fe80 fe80 commented Mar 10, 2020

It's for for doesn't add images, registry and instances class

@fe80 fe80 requested a review from a team as a code owner March 10, 2020 23:54
@fe80 fe80 force-pushed the fe80_hiera_resources branch from 9eeb382 to fed92f4 Compare March 11, 2020 00:09
@codecov-io
Copy link

codecov-io commented Mar 11, 2020

Codecov Report

Merging #586 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #586   +/-   ##
=======================================
  Coverage   28.02%   28.02%           
=======================================
  Files          19       19           
  Lines         685      685           
=======================================
  Hits          192      192           
  Misses        493      493           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 031e699...fed92f4. Read the comment docs.

@sanfrancrisko sanfrancrisko changed the title add lookup hiera resource in init class Add Hiera lookups for resources in init.pp Mar 13, 2020
Copy link
Contributor

@sanfrancrisko sanfrancrisko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @fe80 !

@sanfrancrisko sanfrancrisko merged commit 144c484 into puppetlabs:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants