Make docker::machine::url configurable #569
Conversation
As docker machine is now in maintanence mode [1] there are forks of it where people might want to download the binary from. [1]: docker/machine#4537
Codecov Report
@@ Coverage Diff @@
## master #569 +/- ##
=======================================
Coverage 28.02% 28.02%
=======================================
Files 19 19
Lines 685 685
=======================================
Hits 192 192
Misses 493 493
Continue to review full report at Codecov.
|
|
Thank you @baurmatt for submitting the PR.Looks good.Could you please add acceptance test to verify the same.Thank you. |
baurmatt
force-pushed
the
feature/machine-docker_machine_url-configurable
branch
from
70c01e4 to
fa7695c
Compare
|
Hey @sheenaajay, thanks for taking a look! :) I've added some acceptance tests but can't current test them because your acceptance jobs just return 'ok' for every run. See latest job in master --> https://travis-ci.org/puppetlabs/puppetlabs-docker/jobs/634742568 Happy to take another look at this after you fixed the CI! :) |
|
@baurmatt Thanks for incorporating the changes. Our Travis doesn't run acceptance tests for this module. Will run the Adhoc jobs on Jenkins and will update you with the results. Thank you. |
|
Please find the test results.Could you please fix the failures.Thank you @baurmatt |
|
Hey @sheenaajay, is there a way for me to test this locally? Because without the possibility (local/Travis/...) to run those tests on my own, this will take ages. I'm afraid, I wont't have the time to add those acceptance tests. |
spec/acceptance/machine_spec.rb
Outdated
| describe file('/usr/local/bin/docker-machine-0.16.1') do | ||
| its('owner') { is_expected.to eq 'root' } | ||
| its('mode') { is_expected.to cmp '0755' } | ||
| it { is_expected.to be_file } |
There was a problem hiding this comment.
Could you please try updating the tests with the similar changes given below https://rspec-puppet.com/tutorial/
is_expected.to contain_file('/etc/logrotate.d/nginx').with({
'ensure' => 'present',
'owner' => 'root',
'group' => 'root',
'mode' => '0444',
})
Please let me know if it doesn't work
There was a problem hiding this comment.
Hey @sheenaajay, sorry but I won't play Github comment ping pong for failing tests. If I'm not able to run the tests locally/on Travis without your intervention I won't build them because it just takes way to much time.
There was a problem hiding this comment.
@baurmatt Yeah, Let me make the changes and run on our Jenkins.
|
|
|
👍 LGTM |
As docker machine is now in maintanence mode 1 there are forks of it
where people might want to download the binary from.