Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal changes to work with podman-docker #562

Merged
merged 2 commits into from
Apr 8, 2020

Conversation

seriv
Copy link
Contributor

@seriv seriv commented Dec 20, 2019

These are the minimal changes for puppet docker module to work on RedHat machines with podman-docker package. It does not have a docker service, and has a different output of 'docker version' command.

@seriv seriv requested a review from a team as a code owner December 20, 2019 19:36
@codecov-io
Copy link

Codecov Report

Merging #562 into master will increase coverage by 0.16%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #562      +/-   ##
==========================================
+ Coverage   28.02%   28.19%   +0.16%     
==========================================
  Files          19       19              
  Lines         685      688       +3     
==========================================
+ Hits          192      194       +2     
- Misses        493      494       +1
Impacted Files Coverage Δ
lib/facter/docker.rb 79.45% <75%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af994cc...7f7d314. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants