Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes puppet run failures with no IPAM driver #329

Merged
merged 1 commit into from
Sep 13, 2018
Merged

Conversation

davejrt
Copy link
Contributor

@davejrt davejrt commented Sep 13, 2018

fixes issue #108

@MWilsonPuppet
Copy link

LGTM

@MWilsonPuppet MWilsonPuppet merged commit 38810ae into master Sep 13, 2018
@tbrouhier
Copy link

tbrouhier commented Sep 14, 2018

fixes issue #108

Hi,

I don't think it does as the reported bug is about a call of empty? on nil and the last report I gave you was about the config

subnet = unless obj['IPAM']['Config'].empty?

"IPAM": {
            "Driver": "",
            "Options": null,
            "Config": null
        },

I guess that this commit is also at risk of having a null Driver instead of an empty object.

Possible solution ?
ipam_driver = unless obj['IPAM']['Driver'].nil? || obj['IPAM']['Driver'].empty?
and the same goes for the config
subnet = unless obj['IPAM']['Config'].nil? || obj['IPAM']['Config'].empty?

@davejrt
Copy link
Contributor Author

davejrt commented Sep 16, 2018

You're correct, this was an error on my part, a new PR will be up shortly

@Ramesh7 Ramesh7 added the bugfix label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants