Fix for registry password not being inserted due to single quotes #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 LGTM |
florindragos
pushed a commit
to florindragos/puppetlabs-docker
that referenced
this pull request
Aug 14, 2018
…ppetlabs#299) * Fix registry password not being inserted due to single quotes * Update tests to accept password with double quotes
|
Thanks for finding that @ConorPKeegan - this drove me totally crazy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The insertion of the single quotes before the 2.0.0 release has caused anything that uses the registry to no longer work. With the single quotes you end up with the login command looking like:
The problem is with
'$password', as single quotes prevent the variable from being changed into the environment variable. You can only insert like this with double quotes.