Remove .length from variable $pin_release in app

[paladox]

This causes

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Unknown function: 'length'. at /etc/puppet/environments/production/modules/apt/templates/pin.pref.epp:4:16 at /etc/puppet/environments/production/modules/apt/manifests/source.pp:92 on node xxx

downstream

We use puppet from Debian stretch

[paladox]

We use puppet 4.8 from stretch.

[tphoney]

closing, and re-openning to force travis to re-kick

[tphoney]

would this be better
if $pin_release and $pin_release.length > 0
Following the logic of the rest of the template.
Many thanks for the code !!! @paladox

[paladox]

Thanks, done.

[paladox]

Causes

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, epp(): Invalid EPP: Syntax error at 'options' at /etc/puppet/environments/production/modules/apt/templates/pin.pref.epp:5:3 at /etc/puppet/environments/production/modules/apt/manifests/pin.pp:74:17 at /etc/puppet/environments/production/modules/redis/manifests/init.pp:9 on node misc2.miraheze.org

[paladox]

and now i get

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Unknown function: 'length'. at /etc/puppet/environments/production/modules/apt/templates/pin.pref.epp:4:33 at /etc/puppet/environments/production/modules/redis/manifests/init.pp:9 on node misc2.miraheze.org

again

[tphoney]

thanks @paladox i will have another look, and get back to you.

[tphoney]

apologies, for the interruption again, what manifest/data where you using to test this ?

[tphoney]

or revert back to what you had, and i will merge.

[paladox]

@tphoney we have this:

apt::pin { 'debian_stretch_backports_redis':
    priority   => 740,
    originator => 'Debian',
    release    => 'stretch-backports',
    packages   => 'redis-server',
}

/~https://github.com/miraheze/puppet/blob/master/modules/redis/manifests/init.pp#L9

/~https://github.com/miraheze/puppet/blob/master/manifests/site.pp#L42

[paladox]

doing

if $pin_release != '' {
  $options = [
    if $release != ''         { "a=${release}" },
    if $codename != ''        { "n=${codename}" },
    if $release_version != '' { "v=${release_version}"},
    if $component != ''       { "c=${component}" },
    if $originator != ''      { "o=${originator}" },
    if $label != ''           { "l=${label}" },
    ].filter |$x| { $x != undef }
   "release ${options.join(', ')}" }

should also work?

I think .length will only work on a array?

[tphoney]

https://forge.puppet.com/puppetlabs/stdlib#length Its a weird one :) depends on the puppet version 4 vs 5. I think, revert to 'if $pin_release ' and i will merge. the same goes for empty

[paladox]

Should this be != ''?

[tphoney]

This looks good™️ 👍. Thanks for the effort you have put in.

[paladox]

your welcome and thanks for merging! :)