Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(FACT-2735) virtual not working on EXADATA baremetal #2004

Merged
merged 1 commit into from
Aug 3, 2020
Merged

(FACT-2735) virtual not working on EXADATA baremetal #2004

merged 1 commit into from
Aug 3, 2020

Conversation

BogdanIrimie
Copy link
Contributor

@BogdanIrimie BogdanIrimie commented Jul 30, 2020 •
edited
Loading

each_line returns the initial string, in our case the output of lspci.

 "example string".each_line{ |line| }
 => "example string"

In case no hypervisor match is found, we want to return nil.

@BogdanIrimie BogdanIrimie added do not merge bug Something isn't working labels Jul 30, 2020
@BogdanIrimie BogdanIrimie requested review from a team July 30, 2020 11:41
@puppetcla
Copy link

CLA signed by all contributors.

@BogdanIrimie
Copy link
Contributor Author

jenkins please test this on windows2012r2-64a

@BogdanIrimie BogdanIrimie changed the title (FACT-2735) Add logging in linux virtual fact. (FACT-2735) virtual not working on EXADATA baremetal Jul 31, 2020
@sebastian-miclea sebastian-miclea merged commit 2030377 into puppetlabs:4.x Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-miclea sebastian-miclea sebastian-miclea approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BogdanIrimie @puppetcla @sebastian-miclea