This repository has been archived by the owner on Jun 19, 2020. It is now read-only.
(FACT-2533) Fix for tests/facts/partitions.rb #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gimmyxd
reviewed
May 12, 2020
lib/resolvers/partitions.rb
Outdated
| @@ -96,6 +96,7 @@ def execute_and_extract_blkid_info | |||
| stdout = Facter::Core::Execution.execute('blkid', logger: log) | |||
| output_hash = Hash[*stdout.split(/^([^:]+):/)[1..-1]] | |||
| output_hash.each { |key, value| output_hash[key] = Hash[*value.delete('"').chomp.split(/ ([^= ]+)=/)[1..-1]] } | |||
| output_hash.each { |_key, value| value['PARTUUID'] = value['PARTUUID'].gsub(/\s/, '') if value['PARTUUID'] } | |||
There was a problem hiding this comment.
using https://ruby-doc.org/core-2.7.1/String.html#method-i-rstrip might solve the issue in a single iteration since the problem seems to be caused by the way we are splitting the value and also taking the last extra whitespace
output_hash.each do |key, value|
output_hash[key] = Hash[*value.delete('"').chomp.rstrip.split(/ ([^= ]+)=/)[1..-1]]
end
``
gimmyxd
approved these changes
May 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem: when retrieving partuuid fact for partitions there is an extra space in it's value
Description of the fix: remove extra space from partuuid value