This repository has been archived by the owner on Jun 19, 2020. It is now read-only.
(FACT-2330) Add ssh fact for Windows OpenSSH feature #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oanatmaria
force-pushed
the
FACT-2330
branch
3 times, most recently
from
fb169e7 to
865fdcf
Compare
gimmyxd
reviewed
Apr 8, 2020
lib/framework/core/file_loader.rb
Outdated
Comment on lines
34
to
35
| require "#{ROOT_DIR}/lib/resolvers/utils/ssh.rb" | ||
| require "#{ROOT_DIR}/lib/resolvers/utils/ssh_helper.rb" |
There was a problem hiding this comment.
Why there is a util/shh and a util/ssh_helper?
This is a bit confusing, alongside the fact that there are also other utils in different locations with different purposes. Could this 2 ssh be a single source?
There was a problem hiding this comment.
util/shh is an object that contains structured information about a ssh key. util/ssh_helper creates an object of type util/shh after creating a fingerprint and extracting other information
BogdanIrimie
reviewed
Apr 8, 2020
oanatmaria
force-pushed
the
FACT-2330
branch
2 times, most recently
from
7b73a76 to
8aad8c3
Compare
Filipovici-Andrei
suggested changes
Apr 8, 2020
oanatmaria
force-pushed
the
FACT-2330
branch
4 times, most recently
from
24e547e to
126eca8
Compare
Filipovici-Andrei
suggested changes
Apr 15, 2020
Filipovici-Andrei
approved these changes
Apr 15, 2020
gimmyxd
reviewed
Apr 15, 2020
|
|
||
| private | ||
|
|
||
| def create_ssh_fact(ssh) |
There was a problem hiding this comment.
Isn't this duplicated in each ssh fact? is there a ticket to solve the duplications?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.