Make sure Black doesn't crash when fmt:off
is used before a closing paren
#4363
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a
# fmt: off
is used before a closing paren, it's invalid as Black demands that the# fmt: on/off
pairs must be on the same level of indentation and in the same block. So this PR choses to ignore it. Previously it would crash as it ends up with one extra closing paren.# fmt: off
before a dict's closing bracket #3458(Also refactored the
convert_one_fmt_off_pair
function a little bit.)Checklist - did you ...
CHANGES.md
if necessary?