Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_WhereExpr type doesn't include all possible Expr classes #27

Closed
jaikdean opened this issue Oct 14, 2019 · 1 comment · Fixed by #28
Closed

_WhereExpr type doesn't include all possible Expr classes #27

jaikdean opened this issue Oct 14, 2019 · 1 comment · Fixed by #28
Labels
bug Something isn't working

Comments

@jaikdean
Copy link
Contributor

I've just updated to 0.7.0 and am getting errors reporting when passing Doctrine\ORM\Query\Expr\Comparison objects into Doctrine\ORM\QueryBuilder::andWhere().

The QueryBuilder stub defines a custom Psalm type @psalm-type _WhereExpr=Expr\Base|string. Unfortunately Doctrine's expression classes don't all extend Doctrine\ORM\Query\Expr\Base.

I believe the type needs changing to @psalm-type _WhereExpr=Expr\Base|Expr\Comparison|string.
@weirdan weirdan added the bug Something isn't working label Oct 14, 2019
weirdan added a commit that referenced this issue Oct 14, 2019
@weirdan
Allow Expr\Comparison in where(), orWhere() and andWhere()
04a9c94 
Fixes #27
@weirdan weirdan mentioned this issue Oct 14, 2019
Merged
@weirdan
Copy link
Member

weirdan commented Oct 14, 2019

Released in 0.7.1. Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow Expr\Comparison in where(), orWhere() and andWhere() psalm/psalm-plugin-doctrine
2 participants
@weirdan @jaikdean