Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: define optional and add missing types #8

Merged
merged 4 commits into from
Mar 11, 2024
Merged

fix: define optional and add missing types #8

merged 4 commits into from
Mar 11, 2024

Conversation

jfagoagas
Copy link
Member

@jfagoagas jfagoagas commented Mar 8, 2024 •
edited
Loading

Description

  • Add missing Optional fields.
  • Improve descriptions for some models.
  • Add missing types.
  • Fix enums with integer types.
  • Remove CloudProfile and ContainerProfile since they have to be one level above.
  • Add GitHub action.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfagoagas jfagoagas requested a review from a team March 8, 2024 13:46
@jfagoagas jfagoagas added no-merge No merge this PR testing-pending This PR/Issue needs tests labels Mar 8, 2024
@jfagoagas jfagoagas removed no-merge No merge this PR testing-pending This PR/Issue needs tests labels Mar 11, 2024
@jfagoagas jfagoagas changed the title fix: define optional and new types fix: define optional and add missing types Mar 11, 2024
@jfagoagas jfagoagas force-pushed the fix-model-definitions branch from de71531 to bfc5de8 Compare March 11, 2024 08:26
@jfagoagas jfagoagas merged commit 81d75b4 into main Mar 11, 2024
@jfagoagas jfagoagas deleted the fix-model-definitions branch March 11, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toniblyx toniblyx toniblyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfagoagas @toniblyx