Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonnet: annotate default container for node-exporter DS #1462

Merged

Conversation

paulfantom
Copy link
Member

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Specify which container is a default in pod.

This simplifies operations like log retrieval. With this change instead of:

kubectl logs <node-exporter-pod> -c node-exporter

we can do

kubectl logs <node-exporter-pod>

Tested in thaum-xyz/ankhmorpork@92f5aba

Type of change

What type of changes does your code introduce to the kube-prometheus? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Changelog entry

Please put a one-line changelog entry below. Later this will be copied to the changelog file.

Specify default container in node-exporter pod

@ArthurSens
Copy link
Member

LGTM, but looks like a comma is missing 😬

@paulfantom paulfantom force-pushed the node-exporter-default-container branch from 14e2908 to 595aa0c Compare October 25, 2021 14:29
@paulfantom paulfantom force-pushed the node-exporter-default-container branch from 595aa0c to fb00e61 Compare October 25, 2021 14:31
@paulfantom
Copy link
Member Author

fixed :)

@paulfantom paulfantom merged commit 0beb368 into prometheus-operator:main Oct 25, 2021
@paulfantom paulfantom deleted the node-exporter-default-container branch October 25, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants