Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade to Go 1.14 #2489

Merged
merged 1 commit into from
May 1, 2020
Merged

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Apr 30, 2020

This fixes #2409.

Signed-off-by: James Peach jpeach@vmware.com

This fixes projectcontour#2409.

Signed-off-by: James Peach <jpeach@vmware.com>
@jpeach jpeach requested review from stevesloka and youngnick April 30, 2020 23:13
@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #2489 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2489   +/-   ##
=======================================
  Coverage   76.61%   76.61%           
=======================================
  Files          68       68           
  Lines        5513     5513           
=======================================
  Hits         4224     4224           
  Misses       1192     1192           
  Partials       97       97           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cc0a56...52dbe4e. Read the comment docs.

Copy link
Member

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

LGTM

@jpeach jpeach merged commit 3f07269 into projectcontour:master May 1, 2020
@jpeach jpeach deleted the fix-go-version-114 branch May 1, 2020 04:54
@jpeach jpeach added this to the 1.5.0 milestone May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Go 1.14
2 participants