Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update DCO guidelines in CONTRIBUTING #2425

Merged
merged 2 commits into from
Apr 9, 2020

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Apr 9, 2020

Update the DCO guidelines in the contribution documentation
to clarify that a real name and email address is required.

Signed-off-by: James Peach jpeach@vmware.com

Update the DCO guidelines in the contribution documentation
to clarify that a real name and email address is required.

Signed-off-by: James Peach <jpeach@vmware.com>
@jpeach jpeach force-pushed the update-contrib-dco branch from 617e8d1 to 9b1ea8c Compare April 9, 2020 00:48
@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #2425 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2425   +/-   ##
=======================================
  Coverage   77.02%   77.02%           
=======================================
  Files          66       66           
  Lines        5475     5475           
=======================================
  Hits         4217     4217           
  Misses       1163     1163           
  Partials       95       95           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c444d4...3d8839d. Read the comment docs.

Copy link
Member

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@stevesloka stevesloka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@stevesloka stevesloka merged commit 8a7825c into projectcontour:master Apr 9, 2020
@jpeach jpeach added this to the 1.5.0 milestone May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants