Handle beginless/endless ranges in facet value #3213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylor-steve
force-pushed
the
facet-to-fq-nil-range
branch
from
ab352c8 to
d460da6
Compare
|
Hey, I just came up with this solution myself too, before finding you had already done exactly what I did! I was also looking to solve projectblacklight/blacklight_range_limit#235 I think I will mark it "Ready for Review" and PR it myself? And back-port to BL8. @taylor-steve let me know if there's a reason it's still in Draft? |
|
Not sure why it's saying there is a single CI job that didn't run (ruby 3.3 / rails 7.2.2 ) , something weird with CI, I'm merging anyway, there's nothing that would make it fail in that special. |
jrochkind
added a commit
to projectblacklight/blacklight_range_limit
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been looking at projectblacklight/blacklight_range_limit#235. It seems like it might be easier to fix that issue if Blacklight handled beginless/endless ranges for facets in the search builder.