P6: Added support of BLE GATT Notification instead of GATT Indication… #10336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
npal-cy
force-pushed
the
SWINTEGRATION-507
branch
4 times, most recently
from
7416b2a to
4778db4
Compare
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
Damian-Nordic,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst and
shana-apple
pullapprove
bot
requested review from
tcarmelveilleux,
vivien-apple,
woody-apple,
yufengwangca and
yunhanw-google
woody-apple
approved these changes
Oct 11, 2021
LuDuda
approved these changes
Oct 11, 2021
smides-nest
reviewed
Oct 21, 2021
|
/rebase |
|
Fast tracking this PR, given it's adding platform code. |
|
/rebase |
2 similar comments
|
/rebase |
|
/rebase |
woody-apple
force-pushed
the
SWINTEGRATION-507
branch
from
9a3a738 to
dc253b3
Compare
|
/rebase |
… for C2 GATT Characteristic. It required by Matter spec (section 4.15.3.2. BTP GATT Service): "... the server SHALL exclusively use C2 to respond to BTP handshake requests and send data to the client via GATT ATT_HANDLE_VALUE_NTF PDUs..."
Co-authored-by: Matt Smith <smides@google.com>
woody-apple
force-pushed
the
SWINTEGRATION-507
branch
from
dc253b3 to
e1cccb2
Compare
andy31415
approved these changes
Oct 27, 2021
JasonLiuZhuoCheng
pushed a commit
to JasonLiuZhuoCheng/connectedhomeip
that referenced
this pull request
Oct 28, 2021
project-chip#10336) * P6: Added support of BLE GATT Notification instead of GATT Indication for C2 GATT Characteristic. It required by Matter spec (section 4.15.3.2. BTP GATT Service): "... the server SHALL exclusively use C2 to respond to BTP handshake requests and send data to the client via GATT ATT_HANDLE_VALUE_NTF PDUs..." * Update src/platform/P6/BLEManagerImpl.cpp Co-authored-by: Matt Smith <smides@google.com> Co-authored-by: nazar.palamar <npal@cypress.com> Co-authored-by: Justin Wood <woody@apple.com> Co-authored-by: Matt Smith <smides@google.com>
carol-apple
pushed a commit
to carol-apple/connectedhomeip
that referenced
this pull request
Oct 28, 2021
project-chip#10336) * P6: Added support of BLE GATT Notification instead of GATT Indication for C2 GATT Characteristic. It required by Matter spec (section 4.15.3.2. BTP GATT Service): "... the server SHALL exclusively use C2 to respond to BTP handshake requests and send data to the client via GATT ATT_HANDLE_VALUE_NTF PDUs..." * Update src/platform/P6/BLEManagerImpl.cpp Co-authored-by: Matt Smith <smides@google.com> Co-authored-by: nazar.palamar <npal@cypress.com> Co-authored-by: Justin Wood <woody@apple.com> Co-authored-by: Matt Smith <smides@google.com>
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
project-chip#10336) * P6: Added support of BLE GATT Notification instead of GATT Indication for C2 GATT Characteristic. It required by Matter spec (section 4.15.3.2. BTP GATT Service): "... the server SHALL exclusively use C2 to respond to BTP handshake requests and send data to the client via GATT ATT_HANDLE_VALUE_NTF PDUs..." * Update src/platform/P6/BLEManagerImpl.cpp Co-authored-by: Matt Smith <smides@google.com> Co-authored-by: nazar.palamar <npal@cypress.com> Co-authored-by: Justin Wood <woody@apple.com> Co-authored-by: Matt Smith <smides@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P6: Added support of BLE GATT Notification instead of GATT Indication for C2 GATT Characteristic.
Problem
Using BLE GATT Notification is required by Matter spec (section 4.15.3.2. BTP GATT Service)
Change overview
Updated BLEManagerImpl.cpp to use GATT Notification instead of GATT Indication for C2 GATT Characteristic
Testing
Manual tested BLE commission procedure after update. Test was done on infineon-p6-lock example. Log attached
commission.log