Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(virtual_poly): Remove unnecessary default from PhantomData #39

Merged
merged 1 commit into from
Jul 20, 2023
Merged

refactor(virtual_poly): Remove unnecessary default from PhantomData #39

merged 1 commit into from
Jul 20, 2023

Conversation

oskarth
Copy link
Collaborator

@oskarth oskarth commented Jul 17, 2023

Fixes additional clippy errors I see when I upgraded my Rust toolchain (had some issues with clippy and Homebrew)

error: use of `default` to create a unit struct
   --> src/ccs/util/virtual_poly.rs:120:29
    |
120 |         phantom: PhantomData::default(),
    |                             ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
note: the lint level is defined here

@oskarth oskarth requested review from CPerezz and arnaucube July 17, 2023 12:09
CPerezz
CPerezz approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@CPerezz CPerezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CPerezz CPerezz merged commit a23c6ab into main Jul 20, 2023
@CPerezz CPerezz deleted the refactor/clippy branch July 20, 2023 07:56
hero78119 pushed a commit to hero78119/SuperNova that referenced this pull request Jan 3, 2024
@samuelburnham
Add benchmark comment action (privacy-scaling-explorations#39)
2d89843 
* Add `!benchmark` PR comment action

* Add benches based on modified source paths

* Split benchmark into three jobs based on modified source paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaucube arnaucube arnaucube approved these changes

@CPerezz CPerezz CPerezz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oskarth @arnaucube @CPerezz