Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HyperNova] Update Eq poly usage to actually use EqPolynomial struct #19

Closed
CPerezz opened this issue Jul 10, 2023 · 1 comment
Closed

[HyperNova] Update Eq poly usage to actually use EqPolynomial struct #19

CPerezz opened this issue Jul 10, 2023 · 1 comment
Assignees
@oskarth
Labels
hypernova

Comments

@CPerezz
Copy link
Member

CPerezz commented Jul 10, 2023

We are currently computing the Eq Polynomial on the fly without any structure for it instead of actually using the EqPolynomial.

The idea is that all of the Espresso Systems structures (not yet including VirtualPolynomial) aren't used and get deprecated.
@oskarth oskarth self-assigned this Jul 17, 2023
@oskarth oskarth mentioned this issue Jul 20, 2023
Merged
oskarth added a commit that referenced this issue Aug 2, 2023
@oskarth
Use polynomial.rs instead of virtual_poly for equality polynomial (#42)
bb7a651 
- Remove custom eq_poly and use EqPolynomial instead
- Update polynomial docs
- Ensures order of evaluation is consistent between for VirtualPoly and
EqPolynomial
- Remove old build_eq_x_r_vec and build_eq_x_r_helper
- Tests around boolean hypercube and other introduced functions to make
endianness explicit etc

Addresses #19
@CPerezz
Copy link
Member Author

CPerezz commented Aug 2, 2023

Resolved via #42

@CPerezz CPerezz closed this as completed Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskarth oskarth

Labels
hypernova
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oskarth @arnaucube @CPerezz