Add trailing visuals to the Textfield component
#3267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling visuals including icon, text, label and counter
Co-authored-by: Cameron Dutro <camertron@gmail.com>
Co-authored-by: Cameron Dutro <camertron@gmail.com>
…en it is too long
…ields-in-datepicker-and-lag-field' into text_field_trailing_visuals
🦋 Changeset detectedLatest commit: a281d0e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
14 tasks
…ields-in-datepicker-and-lag-field' into text_field_trailing_visuals
…components into text_field_trailing_visuals
camertron
requested review from
lukasoppermann and
langermank
and removed request for
a team
|
The original PR, #3237, has been approved. Using my admin privileges to merge this one. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This PR is a re-submission of #3237 with several small fixes. I have re-created it so that our CI will run correctly.
Screenshots
See the original PR: #3237
Integration
No changes necessary in production; these changes are purely additive.
Risk Assessment
What approach did you choose and why?
See the original PR: #3237
Accessibility
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.