-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant marketing layout selectors #1373
Remove redundant marketing layout selectors #1373
Conversation
🦋 Changeset detectedLatest commit: 46b6f6a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonrohan Are the utility classes like .top-n0
removed in this PR? If so, I guess this would need to be a major release and added to the deprecations?
Also, would it be possible to run the versionDeprecations
script in every PR and not just once merged into main
? Or is that bad for performance?
They are 🙏 I've added all the deprecated selectors to |
@simurai Also bumped it to a major release 🙏 would love your fresh 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
This PR removes redundant marketing layout selectors by checking for
0
inmarketing/utlities/layout.scss
:This change removes these selectors from the
marketing-utilities
bundle (all redundant):