-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ConfirmDialog: No way to distinguish reject and close button action being fired #17512
Comments
Due to PrimeTek's demanding roadmap for PrimeNG, this issue is available for anyone to work on. Make sure to reference this issue in your pull request. ✨ Thank you for your contribution! ✨ |
@majkers In the end, you implemented the same approach I initially used but added the (visibleChange) emitter. I believe the best solution would be to introduce a new property within the Confirmation interface. |
Actually the difference is in the details. I dont use banana box together with change event and do not touch setter for visible like You did. I also try to use primeng methods and do not rename them |
fixed in #17713 |
Describe the bug
I've just updated to primeNG 19 from 17. I've noticed that close method from confirmDialog is not being fired since confirmDialog uses dialog internally. And that is why now there is no way to distinguish between reject and close button being fired. It was working ok in primeNG 17 version.
As a reproducer You can check showcase and basic confirmDialog on https://primeng.org/confirmdialog You can see subscribing to reject never fires with close event. Some time ago it was possible like that: #3428 (comment)
Pull Request Link
No response
Reason for not contributing a PR
Other Reason
No response
Reproducer
https://primeng.org/confirmdialog
Environment
N/A
Angular version
19.1.3
PrimeNG version
v19
Node version
20.18.1
Browser(s)
All
Steps to reproduce the behavior
Expected behavior
I expect to fire reject event with ConfirmEventType.CANCEL as close method in confirmdialog.ts states
The text was updated successfully, but these errors were encountered: