Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynamicDialog: Docs of autoZIndex map not its implementation #17014

Closed
shaman-apprentice opened this issue Dec 11, 2024 · 0 comments · Fixed by #17082
Closed

DynamicDialog: Docs of autoZIndex map not its implementation #17014

shaman-apprentice opened this issue Dec 11, 2024 · 0 comments · Fixed by #17082
Assignees
@mehmetcetin01140
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone
18.0.1

Comments

@shaman-apprentice
Copy link
Contributor

Describe the bug

dynamicdialogconfig.props.autoZIndex claims that default value is false. But in its implementation it is undefined and auto z-index is applied to everything which has not autoZIndex === false

Environment

Browser

Reproducer

No response

Angular version

18.x.x

PrimeNG version

18.0.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

22.10.0

Browser(s)

Chrome

Steps to reproduce the behavior

  1. open dynamic dialog without passing a value for autoZIndex config property

Expected behavior

autoZIndex is not applied or the documentation gets updated.
@shaman-apprentice shaman-apprentice added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 11, 2024
@shaman-apprentice shaman-apprentice mentioned this issue Dec 11, 2024
Closed
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 16, 2024
@mertsincan mertsincan added this to the 18.0.1 milestone Dec 16, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 16, 2024
mehmetcetin01140 added a commit that referenced this issue Dec 17, 2024
@mehmetcetin01140
Fixed #17014 | DynamicDialog: Docs of autoZIndex map not its implemen…
136a802 
…tation
@mehmetcetin01140 mehmetcetin01140 mentioned this issue Dec 17, 2024
Merged
mehmetcetin01140 added a commit that referenced this issue Dec 17, 2024
@mehmetcetin01140
Merge pull request #17082 from primefaces/issue-17014
dd92f22 
Fixed #17014 | DynamicDialog: Docs of autoZIndex map not its implemen…
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
PrimeNG
Status: Done
Milestone
18.0.1
Development

Successfully merging a pull request may close this issue.

Fixed #17014 | DynamicDialog: Docs of autoZIndex map not its implemen… primefaces/primeng
3 participants
@shaman-apprentice @mertsincan @mehmetcetin01140