Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panel Menu - wrong class when using routerLink #16683

Closed
YouZag opened this issue Nov 2, 2024 · 0 comments
Closed

Panel Menu - wrong class when using routerLink #16683

YouZag opened this issue Nov 2, 2024 · 0 comments
Assignees
@mehmetcetin01140
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone
18.0.0-rc.2

Comments

@YouZag
Copy link

YouZag commented Nov 2, 2024 •
edited
Loading

Describe the bug

Using routerLink on a top level menu item with the Panel Menu, the css class applied is p-panelmenu-header-action and it should be p-panelmenu-header-link. Children are ok and other parent types seem to be ok.

Environment

It's late and the house is quiet.

Reproducer

No response

Angular version

18.2

PrimeNG version

18.0.0-beta.3

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

v20.16.0

Browser(s)

Chrome

Steps to reproduce the behavior

Create a panel menu with a first level item using routerLink.

Expected behavior

.p-panelmenu-header-link to be the class used.
@YouZag YouZag added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 2, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 19, 2024
@mertsincan mertsincan added this to the 18.0.0-rc.2 milestone Nov 19, 2024
@mertsincan mertsincan removed this from PrimeNG Nov 20, 2024
mehmetcetin01140 added a commit that referenced this issue Nov 25, 2024
@mehmetcetin01140
Fixed #16683 | Panel Menu - wrong class when using routerLink
1f9d1eb
@mehmetcetin01140 mehmetcetin01140 mentioned this issue Nov 25, 2024
Merged
mehmetcetin01140 added a commit that referenced this issue Nov 25, 2024
@mehmetcetin01140
Merge pull request #16834 from primefaces/issue-16683
08baa38 
Fixed #16683 | Panel Menu - wrong class when using routerLink
@mehmetcetin01140 mehmetcetin01140 closed this as completed by moving to Done in PrimeNG Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
PrimeNG
Status: Done
Milestone
18.0.0-rc.2
Development

No branches or pull requests
3 participants
@mertsincan @YouZag @mehmetcetin01140