Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select (v18): overlap between outline and border with invalid state #16577

Closed
jicedtea opened this issue Oct 17, 2024 · 1 comment
Closed

Select (v18): overlap between outline and border with invalid state #16577

jicedtea opened this issue Oct 17, 2024 · 1 comment
Assignees
@cagataycivici
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
18.0.0-rc.2

Comments

@jicedtea
Copy link

Describe the bug

Related:
#16407
bf8423b

Select
image
InputText
image

Environment

All

Reproducer

https://v18.primeng.org/select#invalid

Angular version

Lastest

PrimeNG version

18

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

Lastest

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@jicedtea jicedtea added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 17, 2024
@jicedtea jicedtea mentioned this issue Oct 17, 2024
Closed
EnricoMessall added a commit to Arematics/primeng that referenced this issue Oct 18, 2024
@EnricoMessall
fix: primefaces#16577
eebff6f 
 + Uses border-color instead of outline as it is used in focus state also
@EnricoMessall EnricoMessall mentioned this issue Oct 18, 2024
Closed
@mertsincan mertsincan added this to the 18.0.0-rc.2 milestone Nov 18, 2024
@mertsincan mertsincan added Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Status: Discussion Issue or pull request needs to be discussed by Core Team labels Nov 18, 2024
@mertsincan mertsincan removed this from PrimeNG Nov 20, 2024
@cagataycivici
Copy link
Member

It works as intended in PrimeVue version, we should check other form components for this as well. Thank you for the heads up.

@cagataycivici cagataycivici removed their assignment Nov 22, 2024
cagataycivici added a commit that referenced this issue Nov 29, 2024
@cagataycivici
Fixed #16577, Fixed #16855
2ead704
@cagataycivici cagataycivici added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Nov 29, 2024
@cagataycivici cagataycivici moved this to Done in PrimeNG Nov 29, 2024
@cagataycivici cagataycivici closed this as completed by moving to Done in PrimeNG Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
PrimeNG
Status: Done
Milestone
18.0.0-rc.2
Development

Successfully merging a pull request may close this issue.

Fixed primefaces#16577 - Select invalid state is wrong Arematics/primeng
4 participants
@cagataycivici @mertsincan @jicedtea @cetincakiroglu