Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primeng v18.beta-2 | Firefox - Switching to dark theme doesn't work #16471

Closed
GitStorageOne opened this issue Oct 2, 2024 · 2 comments
Closed

Primeng v18.beta-2 | Firefox - Switching to dark theme doesn't work #16471

GitStorageOne opened this issue Oct 2, 2024 · 2 comments
Assignees
@cetincakiroglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
18.0.0-beta.3

Comments

@GitStorageOne
Copy link

GitStorageOne commented Oct 2, 2024 •
edited
Loading

Describe the bug

https://primeng.org (17.18.11) - Switching to dark theme works.
https://v18.primeng.org (beta.2) - Switching to dark theme doesn't work (even after cleaning browser cache).
(no issues with beta.1)

Environment

No environment - issue reproduced with v18.primeng.org.

Reproducer

No response

Angular version

18.0.1

PrimeNG version

18.0.0-beta-2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

Browser(s)

Firefox 130.0.1; 131

Steps to reproduce the behavior

  1. Use Firefox 131.
  2. Go to https://v18.primeng.org (beta.2)
  3. Try to enable dark theme.
  4. Nothing happens.

Expected behavior

Dark theme should work.
@GitStorageOne GitStorageOne added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 2, 2024
@cetincakiroglu cetincakiroglu added this to the 18.0.0-beta.3 milestone Oct 11, 2024
@cetincakiroglu cetincakiroglu self-assigned this Oct 16, 2024
@cetincakiroglu cetincakiroglu added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Oct 16, 2024
@cetincakiroglu
Copy link
Contributor

Hi,

Thanks a lot for testing the beta and reporting the issue!

cetincakiroglu added a commit that referenced this issue Oct 16, 2024
@cetincakiroglu
Refactor for firefox, fixes #16471
e86e148
@cetincakiroglu
Copy link
Contributor

Fixed in e86e148

@cetincakiroglu cetincakiroglu removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cetincakiroglu cetincakiroglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
18.0.0-beta.3
Development

No branches or pull requests
2 participants
@GitStorageOne @cetincakiroglu