Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table: Numeric Filter #15512

Closed
ethanolree opened this issue May 9, 2024 · 3 comments · Fixed by #15592 · 4 remaining pull requests
Closed

Table: Numeric Filter #15512

ethanolree opened this issue May 9, 2024 · 3 comments · Fixed by #15592 · 4 remaining pull requests
Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.17.0

Comments

@ethanolree
Copy link

Describe the bug

The Numeric Filter is broken on the ColumnFilter as the currency input was changed to a boolean. However, the currency input on the InputNumber component is still a string and is treated as such. This breaks all numeric filtering on the table.

image

Environment

PrimeNG

Reproducer

No response

Angular version

17.13.1

PrimeNG version

17.15.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

Should be able to use the numeric filter type on the ColumnFilter
@ethanolree ethanolree added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 9, 2024
@F3KTOR
Copy link
Contributor

F3KTOR commented May 11, 2024

What should be done here? Convert the currency input inside the InputNumber into a boolean | undefined or to convert the currency inside the table.ts back to string?

@ethanolree
Copy link
Author

@F3KTOR I would say it should be converted back to a string in the table component since that's the way it is in the InputNumber component

F3KTOR added a commit to F3KTOR/primeng that referenced this issue May 14, 2024
@F3KTOR
primefaces#15512 Table: Numeric Filter - issue fixed by converting th…
8dbf149 
…e input type of currency into string from boolean | undefined
@F3KTOR F3KTOR mentioned this issue May 14, 2024
Closed
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 16, 2024
@cetincakiroglu cetincakiroglu added this to the 17.16.2 milestone May 16, 2024
@cetincakiroglu cetincakiroglu mentioned this issue May 16, 2024
Merged
@cetincakiroglu
Copy link
Contributor

Fixed in #15592

@cetincakiroglu cetincakiroglu added the LTS-PORTABLE Issue's fix will be ported to supported LTS versions label May 16, 2024
@Rodolphe33 Rodolphe33 mentioned this issue Jun 11, 2024
Open
@diaz-rigo diaz-rigo mentioned this issue Jun 20, 2024
Open
@gbarron2014 gbarron2014 mentioned this issue Jun 27, 2024
Open
@diaz-rigo diaz-rigo mentioned this issue Jun 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.17.0
3 participants
@cetincakiroglu @ethanolree @F3KTOR