remove circular ref and golf implementation

[JoviDeCroock]

Fixes #2515

[github-actions]

Size Change: +29 B (0%)

Total Size: 41.7 kB

Filename	Size	Change
dist/preact.js	4.02 kB	+5 B (0%)
dist/preact.min.js	4.05 kB	+3 B (0%)
dist/preact.module.js	4.05 kB	+8 B (0%)
dist/preact.umd.js	4.09 kB	+8 B (0%)
jsx-runtime/dist/jsxRuntime.js	298 B	+2 B (0%)
jsx-runtime/dist/jsxRuntime.module.js	306 B	+1 B
jsx-runtime/dist/jsxRuntime.umd.js	375 B	+2 B (0%)

ℹ️ View Unchanged

Filename	Size	Change
compat/dist/compat.js	3.18 kB	0 B
compat/dist/compat.module.js	3.19 kB	0 B
compat/dist/compat.umd.js	3.23 kB	0 B
debug/dist/debug.js	3.12 kB	0 B
debug/dist/debug.module.js	3.11 kB	0 B
debug/dist/debug.umd.js	3.21 kB	0 B
devtools/dist/devtools.js	184 B	0 B
devtools/dist/devtools.module.js	195 B	0 B
devtools/dist/devtools.umd.js	260 B	0 B
hooks/dist/hooks.js	1.13 kB	0 B
hooks/dist/hooks.module.js	1.15 kB	0 B
hooks/dist/hooks.umd.js	1.2 kB	0 B
test-utils/dist/testUtils.js	437 B	0 B
test-utils/dist/testUtils.module.js	439 B	0 B
test-utils/dist/testUtils.umd.js	515 B	0 B

_{compressed-size-action}

[andrewiggins]

LGTM

[github-actions]

📊 Tachometer Benchmark Results

Summary

duration

• 02_replace1k: unsure 🔍 -1% - +2% (-1.63ms - +2.85ms)
  ^{preact-local vs preact-master}
• 03_update10th1k_x16: unsure 🔍 -5% - +4% (-1.66ms - +1.45ms)
  ^{preact-local vs preact-master}
• many_updates: unsure 🔍 -12% - +2% (-6.15ms - +1.17ms)
  ^{preact-local vs preact-master}
• text_update: unsure 🔍 -2% - +7% (-0.05ms - +0.21ms)
  ^{preact-local vs preact-master}

window.usedJSHeapSize

• 02_replace1k: slower ❌ 0% - 0% (0.00ms - 0.01ms)
  ^{preact-local vs preact-master}
• 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
  ^{preact-local vs preact-master}
• many_updates: slower ❌ 0% - 0% (0.00ms - 0.00ms)
  ^{preact-local vs preact-master}
• text_update: slower ❌ 0% - 0% (0.00ms - 0.00ms)
  ^{preact-local vs preact-master}

Results

02_replace1k

• Browser: chrome-headless 86.0.4240.183
• Sample size: 50
• Built by: CI #464

• Commit: b785f5f

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	126.67ms - 129.91ms	-	unsure 🔍 -2% - +1% -2.85ms - +1.63ms
preact-local	127.35ms - 130.45ms	unsure 🔍 -1% - +2% -1.63ms - +2.85ms	-

window.usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	3.56ms - 3.57ms	-	faster ✔ 0% - 0% 0.00ms - 0.01ms
preact-local	3.57ms - 3.58ms	slower ❌ 0% - 0% 0.00ms - 0.01ms	-

03_update10th1k_x16

• Browser: chrome-headless 86.0.4240.183
• Sample size: 60
• Built by: CI #464

• Commit: b785f5f

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	33.61ms - 35.72ms	-	unsure 🔍 -4% - +5% -1.45ms - +1.66ms
preact-local	33.42ms - 35.70ms	unsure 🔍 -5% - +4% -1.66ms - +1.45ms	-

window.usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	3.50ms - 3.51ms	-	unsure 🔍 -0% - +0% -0.01ms - +0.01ms
preact-local	3.50ms - 3.51ms	unsure 🔍 -0% - +0% -0.01ms - +0.01ms	-

many_updates

• Browser: chrome-headless 86.0.4240.183
• Sample size: 70
• Built by: CI #464

• Commit: b785f5f

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	49.56ms - 54.64ms	-	unsure 🔍 -3% - +13% -1.17ms - +6.15ms
preact-local	46.97ms - 52.25ms	unsure 🔍 -12% - +2% -6.15ms - +1.17ms	-

window.usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	4.85ms - 4.85ms	-	faster ✔ 0% - 0% 0.00ms - 0.00ms
preact-local	4.85ms - 4.85ms	slower ❌ 0% - 0% 0.00ms - 0.00ms	-

text_update

• Browser: chrome-headless 86.0.4240.183
• Sample size: 250
• Built by: CI #464

• Commit: b785f5f

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	3.06ms - 3.24ms	-	unsure 🔍 -7% - +1% -0.21ms - +0.05ms
preact-local	3.13ms - 3.33ms	unsure 🔍 -2% - +7% -0.05ms - +0.21ms	-

window.usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	0.82ms - 0.82ms	-	faster ✔ 0% - 0% 0.00ms - 0.00ms
preact-local	0.82ms - 0.82ms	slower ❌ 0% - 0% 0.00ms - 0.00ms	-

_{tachometer-reporter-action v2 for CI}

[coveralls]

Coverage remained the same at 100.0% when pulling 6b3da65 on golf-circular-ref into e247e47 on master.

[developit]

Can we try using an integer counter here instead of the objects? That would get rid of the 7% memory usage increase.

[JoviDeCroock]

moving it to options seems to have hurt perf quite a bit 😅