Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes some php ext installs as they are already installed in base #848

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

efremovd
Copy link
Contributor

@efremovd efremovd commented Aug 30, 2022

Hi,

In the #845 I mentioned that docker builds seem like fails. Issue is with building iconv lib. I've looked around and it seems this modules are already installed in base image and there is no need to add them again.

Here is an output

$ docker run php:7.4-cli-alpine -m 
[PHP Modules]
Core
ctype
curl
date
dom
fileinfo
filter
ftp
hash
iconv
json
libxml
mbstring
mysqlnd
openssl
pcre
PDO
pdo_sqlite
Phar
posix
readline
Reflection
session
SimpleXML
sodium
SPL
sqlite3
standard
tokenizer
xml
xmlreader
xmlwriter
zlib

[Zend Modules]

So in this PR I've removed:

  • iconv
  • mbstring
  • fileinfo

as they are already present in base image.

This PR is also closes #845

@prasathmani prasathmani merged commit 2a2d81c into prasathmani:master Aug 31, 2022
ner00 pushed a commit to ner00/tinyfilemanager that referenced this pull request May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker builds are seems failing
2 participants