修复：错误的 URL 有效性验证正则表达式 #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
感谢PR |
|
目前发现不能兼容 ipv6 的url 例如：http://[2409:8134:50:e2bf:7d96:6c9:280:1234]:5000 |
pppscn
added a commit
that referenced
this pull request
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
我在导入飞书机器人的时候遇到了提示 Webhook URL 无效的问题，检查了代码发现用于验证 URL 的正则应该是错误的，因此有了这个 PR。
请见当前正则的测试以及新正则的测试。
注意这个 PR 去掉了
ftp和file两个协议，如果这个是必须的话，可能要更新一下正则。