Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Resizing errors" #262

Merged
merged 3 commits into from
May 7, 2019
Merged

"Resizing errors" #262

merged 3 commits into from
May 7, 2019

Conversation

kangaroo42
Copy link

No description provided.

@kangaroo42 kangaroo42 requested a review from a team as a code owner May 6, 2019 20:08
@@ -82,6 +82,8 @@ def prepare_resource(self, game_object):
self.register_renderable(game_object)

source_image = self.resources[image_name]
if game_object.size <= 0:
return None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer this up 4 lines, but this arguably just fine.

@AstraLuma
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request May 7, 2019
262: "Resizing errors" r=astronouth7303 a=kangaroo42



Co-authored-by: alby37135 <skang05@dcs.bbk.ac.uk>
@AstraLuma AstraLuma added the bors Someone has bors r+ this PR label May 7, 2019
@bors
Copy link
Contributor

bors bot commented May 7, 2019

Build succeeded

  • docs
  • Linux container:python:3.6-slim
  • Linux container:python:3.7-slim
  • Windows container:python:3.6-windowsservercore-1809
  • Windows container:python:3.7-windowsservercore-1809
  • macOS PYTHON:3.6.8
  • macOS PYTHON:3.7.2

@bors bors bot merged commit e09d2fa into ppb:master May 7, 2019
@AstraLuma AstraLuma mentioned this pull request May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bors Someone has bors r+ this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants