Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds CODEOWNERS #191

Merged
merged 4 commits into from
Apr 2, 2019
Merged

Adds CODEOWNERS #191

merged 4 commits into from
Apr 2, 2019

Conversation

pathunstrom
Copy link
Collaborator

No description provided.

@pathunstrom pathunstrom changed the title Adds CODEOWNERS WORKING Adds CODEOWNERS Dec 10, 2018
@AstraLuma
Copy link
Member

Does WORKING mean "Work in Progress" or "Please merge"?

@pathunstrom
Copy link
Collaborator Author

Work in Progress. I was reading the documentation to make sure I didn't miss anything obvious.

@pathunstrom pathunstrom changed the title WORKING Adds CODEOWNERS WIP Adds CODEOWNERS Dec 10, 2018
@nbraud
Copy link
Contributor

nbraud commented Mar 29, 2019

@pathunstrom From the CODEOWNER documentation, this looks reasonable.
Is there any blocker on merging?

@nbraud
Copy link
Contributor

nbraud commented Mar 29, 2019

PS: I'd rather have the Github-specific things tucked away under .github/, but it's not a strong preference.

@pathunstrom
Copy link
Collaborator Author

pathunstrom commented Mar 29, 2019 •
edited
Loading

I thought things like codeowners function on everything in that directory and lower. Did I miss some docs on this?

Yup. I did. Will move that over.

@nbraud
Copy link
Contributor

nbraud commented Mar 29, 2019

There's a section on CODEOWNERS file location in the Github docs.

@pathunstrom pathunstrom changed the title WIP Adds CODEOWNERS Adds CODEOWNERS Mar 29, 2019
@pathunstrom pathunstrom requested a review from AstraLuma March 29, 2019 17:54
@pathunstrom pathunstrom self-assigned this Mar 29, 2019
@pathunstrom pathunstrom merged commit 583dc6c into ppb:master Apr 2, 2019
@pathunstrom pathunstrom deleted the codeowners branch April 5, 2019 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbraud nbraud nbraud approved these changes

@AstraLuma AstraLuma Awaiting requested review from AstraLuma

Assignees

@pathunstrom pathunstrom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pathunstrom @AstraLuma @nbraud