Add isPositron context key #5673
Conversation
| @@ -25,6 +25,9 @@ CONSTANT_VALUES.set('isEdge', isEdge); | |||
| CONSTANT_VALUES.set('isFirefox', isFirefox); | |||
| CONSTANT_VALUES.set('isChrome', isChrome); | |||
| CONSTANT_VALUES.set('isSafari', isSafari); | |||
| // --- START POSITRON --- | |||
There was a problem hiding this comment.
Nit, instead of capitals, we've tried to be consistent with Start Positron and End Positron, mixed case, for these change region markers.
There was a problem hiding this comment.
I'm not sure why I thought we always used capitals. 🤯
| // --- Start Positron --- | ||
| test('Positron Context Key', () => { | ||
| assert.ok(ContextKeyExpr.has('isPositron').equals(ContextKeyExpr.true())); | ||
| }); | ||
| // --- End Positron --- |
There was a problem hiding this comment.
Agreed this should be enough to verify the context key works for now 👍
If we'd like to test in an extension, one idea is to add a command to positron-zed which has enablement based on the Positron context? Then we can verify that the context key is working if the command is available in the Command Prompt.
extensions/positron-zed/package.json (I think something like this might work, but untested!)
{
"category": "Zed",
"command": "zed.checkIsPositronContext",
"title": "Check that the isPositron context key is set",
"enablement": "isPositron"
},The PWB extension will be leveraging this context key soon, so we can also wait for that work to confirm the context key functionality: /~https://github.com/rstudio/rstudio-workbench-vscode-ext/issues/279
Address #5339
Adds a
isPositroncontext key that istrue. This can be used with extensions like this:{ "category": "Python", "command": "python.createEnvironment", "title": "%python.command.python.createEnvironment.title%", "enablement": "isPositron" },It can also be used internally with
IsPositronContextorContextKeyExpr.has('isPositron')if we had an existential crisis.QA Notes
Nothing uses this and the unit test is enough to know that the key is available.