-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Explorer: Visually distinguish column names with leading/trailing whitespace or empty string #5653
Conversation
15342be
to
8b788ba
Compare
E2E Tests 🚀 ? |
8687996
to
a15743a
Compare
a15743a
to
dc14c13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a big improvement, and so much more clear! 🙌
- The leading/trailing whitespace treatment looks great and consistent for both R and Python.
- The empty string column names for Python look great.
- The empty string column names for R are still rendering like this:
Does there need to be a backend change for the R case? As far as I can tell, the column name is literally just an empty string so I'm not sure why it may be rendering different.
fbb0cb6
to
c83ab2f
Compare
Indeed -- Ark is explicitly formatting empty column names like that, so we can change it to return a length-0 string: /~https://github.com/posit-dev/ark/blob/a569d6ee15d85723aec5625620c0593a7a8476a7/crates/ark/src/data_explorer/r_data_explorer.rs#L583 |
I'll go ahead and merge this and then make a PR to adjust the empty column representation returned by Ark |
Aims to address #3084, #3089. Related to #5652, we also cannot distinguish empty strings or strings with leading whitespace in column names both in the data grid headers and the summary panel.
This PR applies the same approach we used for data cells to format column names in the grid headers and the summary pane. The appearance is could potentially be a bit odd because we use non-fixed-width fonts.
e2e: @:data-explorer