fix: Fix one edge case (out of many) of int128 literals not working #20830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itamarst
changed the title
github-actions
bot
added
fix
2 tasks
|
The test failure doesn't seem to be related to this PR? |
itamarst
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20830 +/- ##
==========================================
+ Coverage 79.63% 79.70% +0.06%
==========================================
Files 1568 1569 +1
Lines 222970 223020 +50
Branches 2544 2546 +2
==========================================
+ Hits 177555 177748 +193
+ Misses 44831 44688 -143
Partials 584 584 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
Jan 22, 2025
| } | ||
| #[cfg(feature = "dtype-i128")] | ||
| { | ||
| AnyValue::Int128(v) |
There was a problem hiding this comment.
Can we still do a i128::try_from. Python has unbounded integers.
There was a problem hiding this comment.
I did that initially, and then the compiler pointed out that v is i128 so the try_from() always succeeds and is redundant. So at the local scope the current code is the correct thing to do I think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20807
See also #20829 for related issues that also seem like they need fixing.