feat: Periodically check python signals ('CTRL-C' handling) #20826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritchie46
requested review from
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
enhancement
|
The uncompressed lib size after this PR is 39.4269 MB. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20826 +/- ##
=======================================
Coverage 79.69% 79.69%
=======================================
Files 1568 1569 +1
Lines 222973 223010 +37
Branches 2544 2545 +1
=======================================
+ Hits 177693 177735 +42
+ Misses 44696 44691 -5
Partials 584 584 ☔ View full report in Codecov by Sentry. |
|
The uncompressed lib size after this PR is 39.4339 MB. |
orlp
reviewed
Jan 21, 2025
| } | ||
|
|
||
| pub fn check_signals() -> PolarsResult<()> { | ||
| let f = unsafe { SIGNALS_FUNCTION.unwrap_or(default) }; |
There was a problem hiding this comment.
Can we use OnceLock here instead? I'm pretty sure this is unsound.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.