fix: Only verify Parquet ConvertedType if no LogicalType is given #20682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Parquet's `LogicalType` replaced the `ConvertedType`, there is no equivalent to certain `LogicalType`s in the ConvertedType (e.g. `Timestamp::Nanos`). Therefore, we should only verify whether the `ConvertedType` is valid if no `LogicalType` was given. Fixes pola-rs#20628.
coastalwhite
requested review from
ritchie46,
orlp and
c-peters
as code owners
github-actions
bot
added
fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20682 +/- ##
==========================================
- Coverage 79.00% 78.99% -0.01%
==========================================
Files 1559 1559
Lines 221152 221217 +65
Branches 2527 2529 +2
==========================================
+ Hits 174711 174760 +49
- Misses 45863 45878 +15
- Partials 578 579 +1 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #20682 will improve performances by 34.09%Comparing Summary
Benchmarks breakdown
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Parquet's
LogicalTypereplaced theConvertedType, there is no equivalent to certainLogicalTypes in the ConvertedType (e.g.Timestamp::Nanos). Therefore, we should only verify whether theConvertedTypeis valid if noLogicalTypewas given.Fixes #20628.