Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't panic but set null type if type is unknown #20647

Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix: Don't panic but set null type if type is unknown #20647

merged 1 commit into from
Jan 9, 2025

Conversation

ritchie46
Copy link
Member

Needed for cloud.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

The uncompressed lib size after this PR is 1115.6178 MB.

@ritchie46 ritchie46 merged commit aca9c80 into main Jan 9, 2025
23 checks passed
@ritchie46 ritchie46 deleted the null branch January 9, 2025 16:01
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.02%. Comparing base (247f0b1) to head (26d7375).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-core/src/series/ops/null.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20647      +/-   ##
==========================================
- Coverage   79.03%   79.02%   -0.02%     
==========================================
  Files        1557     1557              
  Lines      220528   220552      +24     
  Branches     2510     2514       +4     
==========================================
- Hits       174303   174281      -22     
- Misses      45651    45698      +47     
+ Partials      574      573       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-peters c-peters added the accepted Ready for implementation label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants