test(python): Fix flaky categorical test #20591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
nameexhaustion
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20591 +/- ##
==========================================
- Coverage 78.97% 78.95% -0.02%
==========================================
Files 1564 1564
Lines 220807 220863 +56
Branches 2510 2510
==========================================
+ Hits 174377 174382 +5
- Misses 45855 45906 +51
Partials 575 575 ☔ View full report in Codecov by Sentry. |
mcrumiller
reviewed
Jan 7, 2025
| @@ -942,7 +942,7 @@ def test_categorical_unique_20539() -> None: | |||
| df.cast({"letter": pl.Categorical}) | |||
| .group_by("number") | |||
| .agg( | |||
| unique=pl.col("letter").unique(), | |||
| unique=pl.col("letter").unique(maintain_order=True), | |||
| unique_with_order=pl.col("letter").unique(maintain_order=True), | |||
There was a problem hiding this comment.
These two aggregations are now identical FYI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/~https://github.com/pola-rs/polars/actions/runs/12650506836/job/35249157771?pr=20590