Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Boolean optional slice pushdown #20315

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

coastalwhite
Copy link
Collaborator

Big whoops.

Fixes #20314.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Dec 16, 2024
@coastalwhite coastalwhite force-pushed the fix/boolean-slice-pushdown branch from 0a8a4f0 to 414e9eb Compare December 16, 2024 14:41
@ritchie46 ritchie46 merged commit 2fc26cf into pola-rs:main Dec 16, 2024
25 checks passed
@coastalwhite coastalwhite deleted the fix/boolean-slice-pushdown branch December 16, 2024 15:40
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.61%. Comparing base (ff95fad) to head (414e9eb).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20315      +/-   ##
==========================================
- Coverage   79.61%   79.61%   -0.01%     
==========================================
  Files        1567     1567              
  Lines      218453   218528      +75     
  Branches     2462     2462              
==========================================
+ Hits       173921   173974      +53     
- Misses      43965    43987      +22     
  Partials      567      567              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong data when doing slice pushdown for boolean in parquet
2 participants