-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new Int128Type
#20232
Merged
Merged
feat: Add new Int128Type
#20232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coastalwhite
changed the title
I128
refactor: Base the Decimal type on an Int128 physical type
Dec 10, 2024
github-actions
bot
added
internal
An internal refactor or improvement
python
Related to Python Polars
rust
Related to Rust Polars
and removed
title needs formatting
labels
Dec 10, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20232 +/- ##
==========================================
- Coverage 79.63% 79.59% -0.04%
==========================================
Files 1565 1565
Lines 218192 218462 +270
Branches 2475 2475
==========================================
+ Hits 173749 173879 +130
- Misses 43876 44016 +140
Partials 567 567 ☔ View full report in Codecov by Sentry. |
coastalwhite
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa,
wence- and
orlp
as code owners
December 12, 2024 08:06
ritchie46
changed the title
refactor: Base the Decimal type on an Int128 physical type
feat: Add new Dec 12, 2024
Int128Type
Very nice! |
2 tasks
stinodego
added
enhancement
New feature or an improvement of an existing feature
and removed
internal
An internal refactor or improvement
title needs formatting
labels
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accepted
Ready for implementation
enhancement
New feature or an improvement of an existing feature
highlight
Highlight this PR in the changelog
python
Related to Python Polars
rust
Related to Rust Polars
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR properly adds an
Int128
type so that theDecimal
type has a valid physical type.