Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new Int128Type #20232

Merged
merged 24 commits into from
Dec 12, 2024
Merged

feat: Add new Int128Type #20232

merged 24 commits into from
Dec 12, 2024

Conversation

coastalwhite
Copy link
Collaborator

@coastalwhite coastalwhite commented Dec 9, 2024

This PR properly adds an Int128 type so that the Decimal type has a valid physical type.

@coastalwhite coastalwhite changed the title I128 refactor: Base the Decimal type on an Int128 physical type Dec 10, 2024
@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Dec 10, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 74.11972% with 147 lines in your changes missing coverage. Please review.

Project coverage is 79.59%. Comparing base (1cd807f) to head (eac30ed).
Report is 126 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-compute/src/cast/mod.rs 7.14% 26 Missing ⚠️
crates/polars-core/src/datatypes/any_value.rs 18.18% 18 Missing ⚠️
...es/polars-core/src/chunked_array/ops/row_encode.rs 75.51% 12 Missing ⚠️
crates/polars-core/src/series/mod.rs 85.71% 12 Missing ⚠️
crates/polars-row/src/encode.rs 86.36% 9 Missing ⚠️
...polars-core/src/series/implementations/duration.rs 0.00% 6 Missing ⚠️
...tes/polars-core/src/series/implementations/time.rs 0.00% 6 Missing ⚠️
...tes/polars-core/src/series/implementations/null.rs 0.00% 5 Missing ⚠️
crates/polars-row/src/decode.rs 78.26% 5 Missing ⚠️
crates/polars-arrow/src/io/ipc/write/schema.rs 0.00% 4 Missing ⚠️
... and 19 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20232      +/-   ##
==========================================
- Coverage   79.63%   79.59%   -0.04%     
==========================================
  Files        1565     1565              
  Lines      218192   218462     +270     
  Branches     2475     2475              
==========================================
+ Hits       173749   173879     +130     
- Misses      43876    44016     +140     
  Partials      567      567              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coastalwhite coastalwhite marked this pull request as ready for review December 12, 2024 08:06
@ritchie46 ritchie46 changed the title refactor: Base the Decimal type on an Int128 physical type feat: Add new Int128Type Dec 12, 2024
@ritchie46 ritchie46 added the highlight Highlight this PR in the changelog label Dec 12, 2024
@ritchie46 ritchie46 merged commit f599e88 into pola-rs:main Dec 12, 2024
27 of 28 checks passed
@alexander-beedie
Copy link
Collaborator

Very nice!

@c-peters c-peters added the accepted Ready for implementation label Dec 14, 2024
@stinodego stinodego added enhancement New feature or an improvement of an existing feature and removed internal An internal refactor or improvement title needs formatting labels Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature highlight Highlight this PR in the changelog python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants