fix: Ensure output height does not change on lazy projection pushdown with aggregations #20223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
nameexhaustion
commented
Dec 9, 2024
| } else { | ||
| // Select the last column projection. | ||
| let mut name = None; | ||
| for (_, plan) in (&*lp_arena).iter(input) { |
There was a problem hiding this comment.
I removed the LP traversal because I don't think it's needed - if the upper node isn't one of the Select / HStack / DataframeScan nodes then it should be safe to take any column
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20223 +/- ##
==========================================
- Coverage 79.63% 79.62% -0.01%
==========================================
Files 1565 1565
Lines 218192 218192
Branches 2475 2475
==========================================
- Hits 173749 173743 -6
- Misses 43876 43882 +6
Partials 567 567 ☔ View full report in Codecov by Sentry. |
nameexhaustion
force-pushed
the
proj-pd-height
branch
from
cb7181b to
77e5d14
Compare
nameexhaustion
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
|
I will take a look a bit later. Always a bit scared hitting this code. |
Closed
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20220
Fixes #20221
Fixes #20337
This would supercede #20222, but because it is a bigger rewrite, I want this to be merged after the next patch release.