-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Deprecate ddof parameter for correlation coefficient #20197
Conversation
let function = FunctionExpr::Correlation { | ||
method: CorrelationMethod::Pearson, | ||
ddof, | ||
ddof: 0u8, | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I change FunctionExpr::Correlation
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can remove ddof
there I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your comment! I moved ddof parameter in FunctionExpr::Correlation
into CorrellationMethod::Covariance
(f00ff2b) .
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20197 +/- ##
==========================================
+ Coverage 79.47% 79.61% +0.14%
==========================================
Files 1555 1564 +9
Lines 216318 217986 +1668
Branches 2456 2478 +22
==========================================
+ Hits 171919 173559 +1640
- Misses 43841 43858 +17
- Partials 558 569 +11 ☔ View full report in Codecov by Sentry. |
Thank you @flowlight0 👍 |
初めてのPR、ありがとうございます! |
Fix #19420