Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Reduce memory copy when scanning from Python objects #20142

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

nameexhaustion
Copy link
Collaborator

Do this by making the backing memory an Arced trait object

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 87.87879% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.56%. Comparing base (bcfa7ec) to head (64560d6).
Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-python/src/file.rs 88.88% 2 Missing ⚠️
crates/polars-plan/src/plans/ir/scan_sources.rs 66.66% 1 Missing ⚠️
crates/polars-python/src/dataframe/io.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20142      +/-   ##
==========================================
- Coverage   79.57%   79.56%   -0.02%     
==========================================
  Files        1563     1563              
  Lines      217395   217396       +1     
  Branches     2472     2472              
==========================================
- Hits       172986   172963      -23     
- Misses      43841    43865      +24     
  Partials      568      568              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 9b491fd into pola-rs:main Dec 5, 2024
20 checks passed
@c-peters c-peters added the accepted Ready for implementation label Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants